-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: update actions to versions that use Node.js 20 #8833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
dbdb402
to
39938c8
Compare
the doc build error:
It is now an error for two different steps to upload artifacts with the same name. Some people do it on purpose, though I do not know whether we do or not. I imagine the change was made out of belief that it was an error that should be diagnosed. the silabs error is the usual spurious build error, which remains not fully understood. |
I opened this issue: carlosperate/arm-none-eabi-gcc-action#49 to ask for that action to be updated. We could submit a PR too. I may also make the -j4 change here too: https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/ |
I fixed this, now it builds |
I took out the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
checkout@v4
has a newshow-progress: true|false
option that allows suppressing progress lines, which can make a log a lot longer. Sounded good to me, so I addedprogress:false
everywhere it was used.upload-artifact@v4
anddownload-artifact@v4
have been completely rewritten, with some upward incompatibilities. I think they should still work for us, though.