Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: update actions to versions that use Node.js 20 #8833

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jan 24, 2024

checkout@v4 has a new show-progress: true|false option that allows suppressing progress lines, which can make a log a lot longer. Sounded good to me, so I added progress:false everywhere it was used.

upload-artifact@v4 and download-artifact@v4 have been completely rewritten, with some upward incompatibilities. I think they should still work for us, though.

tannewt
tannewt previously approved these changes Jan 24, 2024
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jepler
Copy link
Member

jepler commented Jan 25, 2024

the doc build error:

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

It is now an error for two different steps to upload artifacts with the same name. Some people do it on purpose, though I do not know whether we do or not. I imagine the change was made out of belief that it was an error that should be diagnosed.

the silabs error is the usual spurious build error, which remains not fully understood.

@dhalbert
Copy link
Collaborator Author

I opened this issue: carlosperate/arm-none-eabi-gcc-action#49 to ask for that action to be updated. We could submit a PR too.

I may also make the -j4 change here too: https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/

@dhalbert dhalbert requested review from tannewt and jepler January 25, 2024 04:45
@dhalbert
Copy link
Collaborator Author

It is now an error for two different steps to upload artifacts with the same name.

I fixed this, now it builds doc-html and doc-latexpdf, instead of two docs.

@dhalbert
Copy link
Collaborator Author

I took out the PARALLEL stuff in tools/build_release_files.py because it wasn't actually used anywhere.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit a54f5c2 into adafruit:main Jan 25, 2024
482 checks passed
@tannewt tannewt deleted the nodejs-20 branch January 25, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.github: update actions to use Node.js 20
3 participants