Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix framebuffer size for pimoroni dvi base #8309

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix framebuffer size for pimoroni dvi base #8309

merged 1 commit into from
Aug 22, 2023

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Aug 21, 2023 •
edited
Loading

@dglaude @RetiredWizard

I think is due to #7922, and the code for the Pimoroni board was not updated.

Tested and working for me, with DVI output.

@dglaude
Copy link

dglaude commented Aug 21, 2023

Working for me too.

@dhalbert dhalbert requested a review from jepler August 21, 2023 23:58
@RetiredWizard
Copy link

Works for me as well, Thanks!

@dglaude dglaude mentioned this pull request Aug 22, 2023
Closed
jepler
jepler approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on other users test reports. Low probability of adversely affecting anything else.

@jepler jepler merged commit 283889b into adafruit:8.2.x Aug 22, 2023
@dhalbert dhalbert deleted the fix-pimoroni-dvi-base branch August 22, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhalbert @dglaude @RetiredWizard @jepler