Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.2.x backport metro esp32s3 #8280

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

dglaude
Copy link

@dglaude dglaude commented Aug 13, 2023

This is a totally untested backport of metro esp32s3 from main to 8.2.x by applying the 4 PR (that touch the file for that board) from @makermelissa in the same order as they were originally applied.
I don't have the hardware to test, but since I did work on the backport for the PicoPad, I felt I could try again to apply my new cherry-picking skill.

PS: Here is what I did in my branch before submitting this PR...

git checkout -b 8.2.x-backport-metro-esp32s3
git cherry-pick 8f1ebdbd1087dc3581e5487d95b7b9720d31090f
git cherry-pick 6030d87025c5db315ac74d29bc80c015e65492da
git cherry-pick ffb1cf116d2fa40df56ac5d4ac22ac784e5e4a2a
git cherry-pick 45b1c42be517fc6c03eed0d5aa101634b6842efd
git push <repo>```

@tannewt
Copy link
Member

tannewt commented Aug 14, 2023

This works for me.

Next time, let's wait for hardware to be available. Only then do we know that it won't change before release. It'll also make testing easier.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 7567f71 into adafruit:8.2.x Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants