Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.2.x backport picopad by @lynt-smitka #8279

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

dglaude
Copy link

@dglaude dglaude commented Aug 13, 2023

All credit to @lynt-smitka for adding the support for PicoPad to main, but the release of 9.0 might be very far, and waiting for that it is confusing end-user to get the right firmware, having to pick one in the S3. The board is targetted at education, so making this as smooth as possible is important.

PicoPad support was not picked up in the recent 8.2.3 release.
This is an attempt at cherry-picking the thing (my first backporting, so I hope this preserve the credit) and could be included in the next 8.2.4, that would be great.

@dglaude
Copy link
Author

dglaude commented Aug 13, 2023

I took an UF2 from the artifacts, it boot and run complex piece of code provided by @lynt-smitka that use the wifi network, ntp and display internal temperature on the screen.
So it "Works for Me."

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it has an extremely low chance of causing any problems, and as you point out it'll be beneficial for those with the boards.

@lynt-smitka
Copy link

Yes, it would be great to have proper download options for PicoPad users. 😊

I'm putting up a beginner's tutorials on how to get started with CircuitPython and PicoPad, and it will come in handy.

@dglaude
Copy link
Author

dglaude commented Aug 13, 2023

@lynt-smitka if you could give a try to the artefact and confirm it also works for you, it will be easier for reviewers without the hardware to accept this PR.

PS: I believe Adafruit will want to make an 8.2.4 release soon that makes the new Metro ESP32S3 more accessible. Both PicoPad and that metro are the only recent board I could find without an easy download. I don't see the backport, but I have identified the four PR needed, I even feel like proposing one myself, but I don't have the hardware.

@lynt-smitka
Copy link

Tried and everyhting works fine 👍

@tannewt tannewt merged commit f353fb1 into adafruit:8.2.x Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants