Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump protomatter to 1.5.10 #8220

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

jepler
Copy link
Member

@jepler jepler commented Jul 26, 2023

"Howdy. A customer was having issues with a long RGB matrix chain on Matrix Portal S3. Made a microscopic change in Protomatter that seems to improve the situation in Arduino. Could you see that the next CircuitPython build gets the same change? (1.5.9 release)"

Furthermore (1.5.10):

I was doing some work on the Arduino side of Protomatter today and found that this latest batch of P4 and P5 matrix panels are super persnickety about the clock signal. Today’s 1.5.10 release should fix this, and the change (just moving some NOPs) ought to work in CircuitPython as well.

I think what might’ve happened is occasionally there’s a PR that fixes one person’s flicker issue, unaware that this may lay waste to other situations. So earlier CircuitPython could sometimes behave better than later releases. Testing today on logic analyzer and six different panels, aiming for 50% duty cycle w/20 MHz CLK seems to produce the most reliable output across different hardware, and the code is now configured for such. Added a note to that repo’s README asking folks to open an issue rather than a PR if they have a problem and a “fix” for flicker, as it really needs monitoring and testing across a bunch of parts before merging.

@jepler
Copy link
Member Author

jepler commented Jul 26, 2023

@PaintYourDragon fyi

@dhalbert
Copy link
Collaborator

User with the issue is here: https://forums.adafruit.com/viewtopic.php?t=203310.

We can point them to the artifact after it's built for them to test, and I could make an 8.2.2 soon.

@PaintYourDragon
Copy link

Thank y’all! If this only partly remedies their problem, think it’s just a matter of further increasing this constant then.

@dhalbert
Copy link
Collaborator

User reports:

With that image + original hardware config (four 64 x 32 RGB Matrixes) + original sketch... No artifacts from the S3 observed when "bit_depth=3". Problems still there when "bit_depth=4"

@PaintYourDragon Would it make sense / is it possible to make that timing parameter bit_depth dependent, or maybe it should be a user-supplied parameter?

xref to adafruit/Adafruit_Protomatter@5f0b40e

@jepler
Copy link
Member Author

jepler commented Aug 5, 2023

This now updates to 1.5.10, and may fix #7912.

@jepler jepler changed the title bump protomatter to 1.5.9 bump protomatter to 1.5.10 Aug 5, 2023
@jepler jepler requested a review from dhalbert August 5, 2023 01:55
@dhalbert
Copy link
Collaborator

dhalbert commented Aug 5, 2023

@PaintYourDragon posted https://forums.adafruit.com/viewtopic.php?p=981739#p981739 this evening. @PaintYourDragon should we wait on this?

@dhalbert dhalbert merged commit 8260f81 into adafruit:8.2.x Aug 10, 2023
@dhalbert
Copy link
Collaborator

I discussed this with @PaintYourDragon, and the problems mentioned in the forum post were not reproducible, so let's merge this.

@chef-wally
Copy link

Thought this might fix #7682 but got this issue when installing CircuitPython 8.2.3 #8303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants