Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial Adafruit Metro ESP32-S3 #8215

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

makermelissa
Copy link
Collaborator

@makermelissa makermelissa commented Jul 25, 2023

I didn't test this due to not having the hardware, but gave @ladyada the compiled firmware to try out.

@makermelissa makermelissa marked this pull request as draft July 25, 2023 15:30
@makermelissa makermelissa marked this pull request as ready for review July 27, 2023 15:09
@makermelissa
Copy link
Collaborator Author

@ladyada tested this a couple of days ago.

@ladyada
Copy link
Member

ladyada commented Jul 27, 2023

please change or add Dn to IOn (matching other Metro boards)
https://github.com/adafruit/circuitpython/blob/main/ports/atmel-samd/boards/metro_m4_express/pins.c#L16

@makermelissa
Copy link
Collaborator Author

D pins added for GPIO 2 - 13.

@makermelissa
Copy link
Collaborator Author

Oh, missed 0 and 1...

@tannewt tannewt requested a review from ladyada July 28, 2023 16:55
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks!

@tannewt tannewt merged commit 0bf50d2 into adafruit:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants