Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32 synthio channels to 12 #8189

Merged
merged 1 commit into from
Jul 25, 2023
Merged

ESP32 synthio channels to 12 #8189

merged 1 commit into from
Jul 25, 2023

Conversation

todbot
Copy link

@todbot todbot commented Jul 21, 2023

I noticed ESP32 boards have the default CIRCUITPY_SYNTHIO_MAX_CHANNELS of 2.
This puts it at 12, like RP2040 and others.

Tested on ESP32S3 QTPy and I2S DAC.

tannewt
tannewt reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhalbert Want this in 8.2?

@dhalbert
Copy link
Collaborator

@dhalbert Want this in 8.2?

I think so!

@todbot, would you be willing to test with ESP32 and ESP32-S2? I'm not sure why @jepler did not increase it for all? Is there significant use of RAM when it's increased, or only if you use more voices?

@jepler
Copy link
Member

jepler commented Jul 24, 2023

fwiw the "significant resource use" is computation & RAM bandwidth

@todbot
Copy link
Author

todbot commented Jul 25, 2023 •
edited
Loading

Tested working on QTPy ESP32-S2 & QTPy ESP32-Pico via web workflow, and Lolin S2 Mini (ESP32-S2) via USB workflow. All report > 2MB free RAM via gc.mem_free(). QTPY ESP32-S3 reported ~140kB RAM free.

dhalbert
dhalbert approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for testing!

@dhalbert
Copy link
Collaborator

Will backport to 8.2.x

@dhalbert dhalbert merged commit 2d53627 into adafruit:main Jul 25, 2023
@dhalbert dhalbert mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@todbot @dhalbert @jepler @tannewt