nrf: prevent I2C hangs #8094
Merged
nrf: prevent I2C hangs #8094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check to make sure that SDA and SCL are in a sane condition before starting any I2C operation. If they are not it tries to rectify it, and then returns an error code if unable to do so.
dhalbert
requested changes
Jun 20, 2023
|
@furbrain Before I approve, I just want to check that you have tried this on hardware after the latest round of changes. |
|
Good point, yes, I have tested it using the code provided in #8093, and the
second `print` statement now produces an OSError - which is what I would
have expected.
Phil
…On Tue, 20 Jun 2023 at 23:39, Dan Halbert ***@***.***> wrote:
@furbrain <https://github.com/furbrain> Before I approve, I just want to
check that you have tried this on hardware after the latest round of
changes.
—
Reply to this email directly, view it on GitHub
<#8094 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW3PXKNII24RSNEEGLWKTTXMIRBVANCNFSM6AAAAAAZMNKUCY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to make sure that SDA and SCL are in a sane condition before starting any I2C operation. If they are not it tries to rectify it, and then returns an error code if unable to do so.