Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAM E54 Xplained Pro: add support for SST26VF064B flash chip #8054

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

tomiahola
Copy link

@tomiahola tomiahola commented Jun 1, 2023

Fixes #8047

dhalbert
dhalbert previously approved these changes Jun 1, 2023
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@dhalbert dhalbert dismissed their stale review June 1, 2023 13:09

build failed

@tannewt
Copy link
Member

tannewt commented Jun 1, 2023

@tomiahola Please test the build for the board under artifacts here: https://github.com/adafruit/circuitpython/actions/runs/5147018667?pr=8054

@dhalbert
Copy link
Collaborator

dhalbert commented Jun 1, 2023

@tannewt Oddly these work:

ports/atmel-samd/boards/bdmicro_vina_d51_pcb7/mpconfigboard.mk:10:EXTERNAL_FLASH_DEVICES = "MX25L51245G","GD25S512MD"
ports/atmel-samd/boards/bdmicro_vina_d51/mpconfigboard.mk:13:EXTERNAL_FLASH_DEVICES = "MX25L12833F","MX25L51245G","GD25S512MD"
ports/atmel-samd/boards/bdmicro_vina_d21/mpconfigboard.mk:10:EXTERNAL_FLASH_DEVICES = "MX25L51245G","GD25S512MD"

Maybe because there are no spaces.

@dhalbert dhalbert merged commit de46be1 into adafruit:main Jun 1, 2023
@tomiahola
Copy link
Author

@tannewt, Hi, I downloaded the .uf2 file under the artifacts and installed it into the board:
Now there is no response from the board, neither CIRCUITPY or USB Drive appears, and no COM port is detected.

@dhalbert
Copy link
Collaborator

dhalbert commented Jun 2, 2023

I apologize this before testing; I misunderstood about whether testing had happened. Since it didn't work before, not such big deal, but sounds like the flash chip definition may be wrong. There is no other board that uses this chip (or the smaller 2MB version), so there may be an error in the chip definition in nvm.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIRCUITPY drive not appearing with SAM E54 Xplained Pro
3 participants