Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web-editor debug on non-standard port using localhost (CORS) #7897

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Fix web-editor debug on non-standard port using localhost (CORS) #7897

merged 1 commit into from
Apr 24, 2023

Conversation

thess
Copy link

@thess thess commented Apr 22, 2023

Using localhost web-editor debugging on non-standard port throws CORS error violation.
This fix allows use of localhost origin independent of port designation.

@tannewt tannewt self-requested a review April 24, 2023 17:17
tannewt
tannewt approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 029c941 into adafruit:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thess @tannewt