Add device name environment variable for web workflow #7846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Apr 10, 2023
| @@ -329,7 +335,8 @@ void supervisor_start_web_workflow(void) { | |||
| mdns_server_construct(&mdns, true); | |||
| mdns.base.type = &mdns_server_type; | |||
| if (!common_hal_mdns_server_deinited(&mdns)) { | |||
| common_hal_mdns_server_set_instance_name(&mdns, MICROPY_HW_BOARD_NAME); | |||
| char *instance_name = strndup(web_instance_name, strlen(web_instance_name)); | |||
There was a problem hiding this comment.
I don't think this will work right because we don't usually use malloc() directly. Instead, I'd just add a static variable to hold the data. Memory allocation is tricky because it can happen via the MP heap or via supervisor.
There was a problem hiding this comment.
Thanks, Scott!
Didn't think of the static variable.
Just updated the PR. I tested again with the ESP32-S3. Please let me know if this would work.
Thanks!
tannewt
approved these changes
Apr 11, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR tries to resolve #7511
settings.tomltemplate that would need to be updated.cp/version.jsonwith aadafruit_feather_esp32s3_nopsramcp/devices.jsonbecause I only have one board with WIFI. It would be great if someone could help testing!Thanks in adnvance!