Adding circle bitmaptools

[jposada202020]

Sorry about the previous PR, badly done on my part.

[FoamyGuy]

I tested this successfully on Feather ESP32-S2 TFT. I did have to merge main into this branch in order to get a build that worked (prior to merging main I got successful builds, but device bootlooped without running code.py or printing any error messages. Seems like some other commit in main fixed that.)

Current functionality looks good to me.

I think it's worth considering tweaking the name of the x/y point arguments to not have a numberin them, but beyond that this seems good to me.

[jposada202020]

Thank you @gamblor21 and @FoamyGuy for the reviews ... probably ill will do the changes later the week, need some headspace to work in C 🍼

[dhalbert]

Finish renaming x0 and y0 to x and y.

[jposada202020]

Thank you very much @dhalbert, Thank you for taking the time to put the explanations. It helps a lot!

[dhalbert]

Could you retest a build to make sure it still works? I did not re-test, I just renamed, and if I made a typo it might have stopped working. Thanks.

[jposada202020]

Yes, will do.

[dhalbert]

@jposada202020 You can collect all the suggestions into a single batch by clicking "Add suggestion to batch". Then after you do all the ones you want in a single commit, you can click the appropriate button again to apply them all at once.

[jposada202020]

Thanks @dhalbert . Sorry 👍🏼

[jposada202020]

@dhalbert It builds no problem, but the now is not drawing a circle, need to troubleshoot why the change in behaviour. Going to put it draft and troubleshoot tonight. Thanks

[dhalbert]

My x0 -> x and y0 -> y changes might not have been completely consistent.

[jposada202020]

Test Code

import time
import displayio
import board
import bitmaptools


display = board.DISPLAY

palette = displayio.Palette(4)
palette.make_transparent(0)
palette[1] = 0xFFFFFF
palette[2] = 0x440044
bitmap = displayio.Bitmap(display.width, display.height, 3)
bg = displayio.TileGrid(bitmap, pixel_shader=palette)

group = displayio.Group()
group.append(bg)


radius = 50

for i in range(25, 480, 100):
    for j in [19, 119, 219, 319]:
        bitmaptools.draw_circle(bitmap, i, j, radius, 1)

display.show(group)

Result

[dhalbert]

Thanks for the quick fix!

[FoamyGuy]

I re-tested the functionality and that part is still looking good to me.

I do think it might be best to use the mp_arg_validate functions instead of "manually" having if statements to validate the range. I've added seperate comments in the specific sections where that is applicable.

[jposada202020]

Changes in 2f3ea81

[FoamyGuy]

Looks good to me. Thanks for adding this functionality @jposada202020!

I tested the latest version successfully with Feather ESP32-S2 TFT and confirmed the bounds validation for x,y and radius. All appears good to me.