Brainboardz_Neuron Updated Pins and Defined Objects #7705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed "CD" from the pin definitions for (MISO, MOSI and SCK pins). Specifically Pins 13, 15 and 14. Added Pin definitions for I2C and SPI objects
Add #defines for SPI_BUS_SCK, SPI_BUS_MOSI and SPI_BUS.MISO
Chnage the SDA pin define to GPIO9 and SCL pin define to GPIO8. This now matches the currect GPIO pins numbers in pins.c The previous GPIO pins number in mpconfigboard.h were incorrect
Added a comma (,) to the the end of the definition for board_spi_obj
Changed incorrect i2C pins assignment in mpconfigboard.h (changed SDA/SCL to GPIO 8/GPIO 9. Rename SD_MOSI, SD_MISO and SD_SCK to MOSI, MISO and SCK Added SPI define in mpconfigboard.h for SPI
|
Note that it's better to create a branch for your PR rather than edit your
I'm not sure what you meant here but any changes to |
|
Hi Dan:
Thanks for the suggestion on not working off my main branch. I will
implement that.
bye for now,
…On Fri, Mar 10, 2023 at 10:06 AM Dan Halbert ***@***.***> wrote:
Note that it's better to create a branch for your PR rather than edit your
main branch. If you do the latter then it can get out of sync with the
upstream main branch. See
https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github/always-work-on-a-branch#create-your-new-branch-2992239.
Don't worry about changing this now, but be aware your main branch may
diverge.
I tried to commit this upstream but for some reason that is not working
properly.
I'm not sure what you meant here but any changes to adafruit/circuitpython
are via pull requests only.
—
Reply to this email directly, view it on GitHub
<#7705 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU2ZOBK5PEDJ2KZZF5OSM73W3M7PRANCNFSM6AAAAAAVWR7YAI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Awesome! Thanks again Dan.
…On Fri, Mar 10, 2023 at 10:25 AM Dan Halbert ***@***.***> wrote:
Merged #7705 <#7705> into
main.
—
Reply to this email directly, view it on GitHub
<#7705 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU2ZOBPK6JMU534ESNXO4MLW3NBVBANCNFSM6AAAAAAVWR7YAI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a board_spi declaration in pins.c. I have also corrected erroneous pin definitions for the SCL and SDA pins (these are actually supposed to be GPIO 8 and GPIO 9) in mpconfigboard.h.
I tried to commit this upstream but for some reason that is not working properly.