Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrainBoardz Neuron Commit (Final I Hope!) - Updated as Per Previous Instructions VID+PID Work #7530

Merged
merged 8 commits into from
Feb 1, 2023

Conversation

BrainBoardz
Copy link

Hi There:

I've sorted out the VID/PID issues (it was actually just a re-install of MU!). I've applied the changes that were requested on the Seventh Commit . Checked the firmware and all work fine. Thanks for all the help with this!

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

As mentioned, please don't open a new PR for each commit. Just push a new commit to the existing PR with your changes. If you close a PR you can reopen it.

Also in the future please write descriptive commit messages, not "Fourth Commit", etc.

Now that this is merged, please submit a PR to https://github.com/adafruit/circuitpython-org to add the board to https://circuitpython.org.

@dhalbert dhalbert merged commit 9ab0733 into adafruit:main Feb 1, 2023
@BrainBoardz
Copy link
Author

BrainBoardz commented Feb 1, 2023 via email

@makermelissa
Copy link
Collaborator

Hi @BrainBoardz, were you able to work on a PR for circuitpython-org? If you need help, we have a guide at https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website.

I was going to throw something up on circuitpython.org in its place for now, but I'm really not sure if this is for the Neuron Z3, Neuron M3, both, or a completely new board. I may just end up hiding it for now until you can get around to working on this.

@BrainBoardz
Copy link
Author

BrainBoardz commented Feb 6, 2023 via email

@BrainBoardz
Copy link
Author

BrainBoardz commented Feb 9, 2023 via email

@makermelissa
Copy link
Collaborator

No worries. All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants