-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BrainBoardz Neuron Commit (Final I Hope!) - Updated as Per Previous Instructions VID+PID Work #7530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
As mentioned, please don't open a new PR for each commit. Just push a new commit to the existing PR with your changes. If you close a PR you can reopen it.
Also in the future please write descriptive commit messages, not "Fourth Commit", etc.
Now that this is merged, please submit a PR to https://github.com/adafruit/circuitpython-org to add the board to https://circuitpython.org.
Hi Dan:
That's great! Thanks for all the help. I'm going to work on the PR for the
circuitpython-org and on the website over the weekend.
bye for now,
…On Tue, Jan 31, 2023 at 11:33 PM Dan Halbert ***@***.***> wrote:
Merged #7530 <#7530> into
main.
—
Reply to this email directly, view it on GitHub
<#7530 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU2ZOBLYGWPPKBA7ALYVYVDWVHRSTANCNFSM6AAAAAAUNDAH2A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hi @BrainBoardz, were you able to work on a PR for circuitpython-org? If you need help, we have a guide at https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website. I was going to throw something up on circuitpython.org in its place for now, but I'm really not sure if this is for the Neuron Z3, Neuron M3, both, or a completely new board. I may just end up hiding it for now until you can get around to working on this. |
Hi Mellisa:
If you could hide it for now I would really appreciate it. It won't be for
long! I'm waiting for final pre-production boards to come in before
submitting my PR to circuit python.org. I'd like to use a
photo of those production units on the site as they are the correct board
color etc. If it can wait a little bit that would be great as the boards
will be arriving soon (they typically take a week or two at most). I was
going to work on the content for the page in the meantime. Alternatively,
if updating the photo later would be not too much of a hassle I can
certainly proceed with what I have and get that to you this week. Please
let me know your preference.
In terms of the Neurons, I have two boards Z3 and M3, but they are
virtually identical in terms of capabilities (the M3 is smaller and does
not have the I2C header). Otherwise, they are identical and use
the same firmware and have the same components. They are both ESP32-S3's
with the same Flash and PSRAM.
…On Mon, Feb 6, 2023 at 5:02 PM Melissa LeBlanc-Williams < ***@***.***> wrote:
Hi @BrainBoardz <https://github.com/BrainBoardz>, were you able to work
on a PR for circuitpython-org? If you need help, we have a guide at
https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website
.
I was going to throw something up on circuitpython.org in its place for
now, but I'm really not sure if this is for the Neuron Z3, Neuron M3, both,
or a completely new board. I may just end up hiding it for now until you
can get around to working on this.
—
Reply to this email directly, view it on GitHub
<#7530 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU2ZOBKZCWOXJGICQTPFA53WWFYF7ANCNFSM6AAAAAAUNDAH2A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi Mellisa:
Thanks for adding the temporary .md file etc. to circuit-python.org. It
looks like I should be getting my final boards delivered next week. I've
already started working on the description
etc. on my fork of the CircuitPython-org repository. So, the plan is to get
this all wrapped up by next week (hopefully!).
bye for now,
…On Mon, Feb 6, 2023 at 5:35 PM Jeremy Littler ***@***.***> wrote:
Hi Mellisa:
If you could hide it for now I would really appreciate it. It won't be for
long! I'm waiting for final pre-production boards to come in before
submitting my PR to circuit python.org. I'd like to use a
photo of those production units on the site as they are the correct board
color etc. If it can wait a little bit that would be great as the boards
will be arriving soon (they typically take a week or two at most). I was
going to work on the content for the page in the meantime.
Alternatively, if updating the photo later would be not too much of a
hassle I can certainly proceed with what I have and get that to you this
week. Please
let me know your preference.
In terms of the Neurons, I have two boards Z3 and M3, but they are
virtually identical in terms of capabilities (the M3 is smaller and does
not have the I2C header). Otherwise, they are identical and use
the same firmware and have the same components. They are both ESP32-S3's
with the same Flash and PSRAM.
On Mon, Feb 6, 2023 at 5:02 PM Melissa LeBlanc-Williams <
***@***.***> wrote:
> Hi @BrainBoardz <https://github.com/BrainBoardz>, were you able to work
> on a PR for circuitpython-org? If you need help, we have a guide at
> https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website
> .
>
> I was going to throw something up on circuitpython.org in its place for
> now, but I'm really not sure if this is for the Neuron Z3, Neuron M3, both,
> or a completely new board. I may just end up hiding it for now until you
> can get around to working on this.
>
> —
> Reply to this email directly, view it on GitHub
> <#7530 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AU2ZOBKZCWOXJGICQTPFA53WWFYF7ANCNFSM6AAAAAAUNDAH2A>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
No worries. All good. |
Hi There:
I've sorted out the VID/PID issues (it was actually just a re-install of MU!). I've applied the changes that were requested on the Seventh Commit . Checked the firmware and all work fine. Thanks for all the help with this!