Rework the coproc API #7359
Rework the coproc API #7359
Conversation
It is now a generic `memorymap` API and an ESP specific `espulp` module. Fixes micropython#7218. Fixes micropython#3234. Fixes micropython#7300.
|
The ULP code to test is here: https://github.com/adafruit/Adafruit_CircuitPython_ULP_Blink Here is a pre-compiled version along with the code.py's for them. (The blink examples compile .c to a .py wrapper library.) The libraries should work on S2 with sx_version=2 but I haven't tested it. They shouldn't be board specific because the pins are dynamically patched into the binary. I plan on polishing this compilation tooling when I'm back from ☃️🎄. |
| else ifeq ($(IDF_TARGET),esp32s2) | ||
| # Modules | ||
| CIRCUITPY_BLEIO = 0 | ||
| CIRCUITPY_ESPULP = 1 | ||
| CIRCUITPY_MEMORYMAP = 1 | ||
|
|
||
| else ifeq ($(IDF_TARGET),esp32s3) | ||
| # Modules | ||
| CIRCUITPY_PARALLELDISPLAY = 0 | ||
| CIRCUITPY_ESPULP = 1 | ||
| CIRCUITPY_MEMORYMAP = 1 | ||
| endif |
There was a problem hiding this comment.
I refactored mpconfigport.mk recently and set the following convention:
# Module on by default and conditionally turned off
CIRCUITPY_ESPULP ?= 1
ifeq ($(IDF_TARGET),esp32)
CIRCUITPY_ESPULP = 0
CIRCUITPY_MEMORYMAP = 0
else ifeq ($(IDF_TARGET),esp32c3)
CIRCUITPY_ESPULP = 0
CIRCUITPY_MEMORYMAP = 0There was a problem hiding this comment.
I'd prefer to do the opposite so that future chips have it off by default.
| if (ulp_used) { | ||
| mp_raise_ValueError_varg(translate("%q in use"), MP_QSTR_ULP); | ||
| } | ||
| self->inited = true; |
There was a problem hiding this comment.
Might want to infer the ULP state from registers.
There was a problem hiding this comment.
This was deliberate because the ULP might already be running when the object is created.
|
@microdev1 After discussion, we are going to merge as is for beta.6 and vacation scheduling reasons, but happy to address further things, probably after the new year. |
It is now a generic
memorymapAPI and an ESP specificespulpmodule.Fixes #7218. Fixes #3234. Fixes #7300.