modbuiltins: Catch most exceptions during dir() #6539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps with Python-compatibility (see issue adafruit#4171) but doesn't completely resolve it. Now, `dir()` still computes any properties of the underlying object, HOWEVER, if the property raises an exception this expression is captured. This ability to capture exceptions always existed in `mp_load_method_protected`, we just need to turn it on via the `catch_all_exc` boolean parameter.
gamblor21
approved these changes
Jun 30, 2022
dhalbert
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with Python-compatibility (see issue #4171) but doesn't completely resolve it.
Now,
dir()still computes any properties of the underlying object, HOWEVER, if the property raises an exception this exception is captured.This ability to capture exceptions always existed in
mp_load_method_protected, we just need to turn it on via thecatch_all_excboolean parameter.