Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.3.x auto esp cache key update #6506

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

dhalbert
Copy link
Collaborator

backport #6494 and #6497 to 7.3.x: cache key fix

jepler added 2 commits June 20, 2022 14:06
I noticed that the latest time we needed to switch the idf key was when
the environment changed from python 3.10.4 to 3.10.5. I don't know if
this is the only cause of needing to change the key, but it seems to be
a good idea to make the key include it.

I think this is what's going on because when I replaced a virtualenv's
"python" with a dangling symlink (same as would occur when python's
version gets bumped), I got a similar error.
@dhalbert
Copy link
Collaborator Author

The CPX CI failures here should be fixed by #6508.

@dhalbert dhalbert requested review from jepler, tannewt and ladyada June 20, 2022 20:58
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 2d14fb1 into adafruit:7.3.x Jun 21, 2022
@dhalbert dhalbert deleted the 7.3.x-auto-esp-cache-key-update branch June 22, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants