Rp2040 pulsein improvements #6450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavePutz Would you like to review this? |
|
I'm currently in Alaska, but will review after returning on Sunday. |
|
Thanks @DavePutz! Sorry for bugging you while you are away. |
DavePutz
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on issue #4664 but I found a few other small issues and instead of opening issues for each I hoped it would be ok if I just submitted one pull request that addressed them all. I tested these changes with a dht22, an ir remote and an rcwl-1601 and all work as expected. Below is a list of changes.
Fixes #4664
Addresses #4946 since just dropping short pulses isn't a valid way to filter out short pulses
Fixes a buffer start index reset bug on line 160 I missed before
Fixes lost counts when state machine is reset unnecessarily
Fixes missing initial count on pin value change line 143
Removes delay after resume pulse
Fix popleft resetting level count
Removes unneeded buf_index
Add call to pause at the beginning of resume
Adds paused attribute to fix .paused always returning true.
Remove unneeded resets of start pointer in .clear and .popleft.