Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new board: Cytron Maker Zero SAMD21 #6432

Merged
merged 10 commits into from
May 25, 2022

Conversation

mlhakimz
Copy link

Hello, can you help to add this new board?

https://my.cytron.io/p-maker-zero-samd21

Thanks.

@dhalbert
Copy link
Collaborator

@mlhakimz There is apparently some extra white space in the pins.c file. Could you look at the "X" item in https://github.com/adafruit/circuitpython/runs/6589280392?check_suite_focus=true, and remove the whitespace. There is a diff in there showing which line. I would edit your PR but something is preventing that (normally there is a box you can check to allow it).

@mlhakimz
Copy link
Author

@dhalbert Thanks for reviewing. I have deleted the white spaces you mentioned.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but one comment about the ordering of the pin names, if you want to change it.

@mlhakimz
Copy link
Author

@dhalbert I'm keeping the pins order for now. Please merge the PR. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants