Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SPI pin names qtpy esp32s3 #6393

Merged
merged 1 commit into from
May 14, 2022
Merged

fix SPI pin names qtpy esp32s3 #6393

merged 1 commit into from
May 14, 2022

Conversation

todbot
Copy link

@todbot todbot commented May 13, 2022

Pin names in board.{SCK,MOSI,MISO} and board.SPI() were a bit off, perhaps because of previously-mentioned board rev. My boards are Rev C, and these changes have been verified to work with an SPI TFT.

dhalbert
dhalbert approved these changes May 14, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these errors!!

I double-checked against the Rev C schematic, and also checked the QT Py ESP32-S2.

@dhalbert dhalbert added this to the 7.3.0 milestone May 14, 2022
@dhalbert dhalbert merged commit 9fb4582 into adafruit:main May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@todbot @dhalbert