Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct errno messages #6376

Merged
merged 1 commit into from
May 10, 2022
Merged

Correct errno messages #6376

merged 1 commit into from
May 10, 2022

Conversation

dhalbert
Copy link
Collaborator

The errno messages for EPERM and ENODEV were wrong. In particular the ENODEV message was confusingly wrong.

This grows builds slightly due to a new string, and alter the errors we see in some circumstances, but I think it's better to have the correct messages. If the mesages are mentioned in any guides, they'll need to be changed, but I think the mentions may only be in issues. I'll do a learn.adafruit.com site search after this is merged.

@dhalbert dhalbert requested review from tannewt and jepler May 10, 2022 18:07
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like an improvement, thanks

@dhalbert
Copy link
Collaborator Author

The motivation is that I am doing I2C debugging. I thought the "Unsupported operation" meant there was some kind of transmission error, but in fact it was "No such device": literally there was no response from the addressed device.

@dhalbert dhalbert merged commit 78695f5 into adafruit:main May 10, 2022
@dhalbert dhalbert deleted the errno-messages branch May 10, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants