-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to CPython docs for subset modules #6341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! good to merge if green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do more of these at once? This generates ~3-4 hours of builds.
I can add a few basic ones so save time if you'd like! I'll do a bunch that are subsets of CPython here |
That's great too, feel free to re-request review when you're done. |
Keep adding as many as you can do - they are easy to review and the fewer builds and merges the better, in this case. Also each commit restarts the builds, so if you can group changes into one commit or submit commits all at once, it will also save time. |
Sounds good! |
You used several different styles of linking, do you want to comment on why? |
I actually was working on the web interface of github when I noticed the shortcut, so my copypasta wasn't too efficient; let me refactor to use that one. |
The directive actually came from the |
If there's a standard order we want the note in, let me know (as in, it should be immediately after the module name and before any other information). See |
If there is a standard order, I'm also happy to just fix it in another PR that adds more documentation so it doesn't have to be rerun here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I checked off the "done" items in #6326. (No need to edit, you can just click on the checkboxes.) |
Working towards #6326, adds links to CPython documentation for the following modules:
time
math
random
os
ssl
socket
" - really itssocketpool
atexit
struct
traceback