Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new board pewpew_lcd #6331

Merged
merged 1 commit into from
May 13, 2022
Merged

Add new board pewpew_lcd #6331

merged 1 commit into from
May 13, 2022

Conversation

deshipu
Copy link

@deshipu deshipu commented May 1, 2022

No description provided.

@deshipu
Copy link
Author

deshipu commented May 1, 2022

I am still working on getting a USB VID/PID pair.

deshipu added a commit to pypewpew/pidcodes.github.com that referenced this pull request May 1, 2022
PewPew is a family of handheld devices running CircuitPython designed
for use in programming workshops. PewPew LCD is a new device in this
family, using a monochrome LCD display.

The VID/PID is required to be able to merge the board definition for
this device into the CircuitPython repository. The pull request for
that is at adafruit/circuitpython#6331
deshipu added a commit to pypewpew/pidcodes.github.com that referenced this pull request May 10, 2022
PewPew is a family of handheld devices running CircuitPython designed
for use in programming workshops. PewPew LCD is a new device in this
family, using a monochrome LCD display.

The VID/PID is required to be able to merge the board definition for
this device into the CircuitPython repository. The pull request for
that is at adafruit/circuitpython#6331
deshipu added a commit to pypewpew/circuitpython-org that referenced this pull request May 10, 2022
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@deshipu
Copy link
Author

deshipu commented May 13, 2022

Anything else I need to do?

@deshipu
Copy link
Author

deshipu commented May 13, 2022

I also have a patch for the circuitpython.org prepared, but I'm waiting for this to land first.

@dhalbert dhalbert merged commit 9028bf2 into adafruit:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants