Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve ticks for displays across VMs #6321

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

dhalbert
Copy link
Collaborator

Fixes #6277.

SAMD21 ticks depend on the event system, which was getting reset between VM instantiations. But permanent displays depend on ticks being on to refresh. Fixed by not resetting the event system when ticks are in use.

@deshipu could you try this? Thanks.

@deshipu
Copy link

deshipu commented Apr 28, 2022

I just tried by flashing the adafruit-circuitpython-hallowing_m0_express-en_US-20220428-90b78fe.uf2 from S3 on my Hallowing M0 Express, but the screen remains dark.

Copy link

@deshipu deshipu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking out the branch and compiling it manually worked. The display now shows the REPL as it should.

@dhalbert
Copy link
Collaborator Author

@deshipu Thanks for testing!

I just tried by flashing the adafruit-circuitpython-hallowing_m0_express-en_US-20220428-90b78fe.uf2 from S3 on my Hallowing M0 Express, but the screen remains dark.

FYI, that is the last merge, not this PR. We don't push tentative PR builds to S3, but you can get the builds from the artifacts, e.g. https://github.com/adafruit/circuitpython/actions/runs/2236406159. If you click on a Details link above, and then choose Summary on that page, you'll get to a page with the artifacts. You can also find the appropriate build on the Actions link at the top of this page: https://github.com/adafruit/circuitpython/actions.

Copy link
Member

@gamblor21 gamblor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Relying on testing by @deshipu

@dhalbert dhalbert merged commit 816a26e into adafruit:main Apr 28, 2022
@dhalbert dhalbert deleted the samd21-ticks-for-display branch April 28, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

displayio: the display does not survive a VM restart on SAMD21
3 participants