handle clearing both RXIC and RTIC interrupts #6240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6237.
Between pico-sdk 1.2.0 and 1.3.0, the
RP2040 RTUART timeout interrupt was enabled as part ofuart_set_irq_enables(). See raspberrypi/pico-sdk#500 and raspberrypi/pico-sdk#504. Our code did not know this interrupt was now enabled, and did not clear it in the interrupt service routine. Random noise on the RX line could cause this interrupt to be triggered, and once triggered, it was not cleared if the data was not read, and I believe it ended up in a tight constantly firing interrupt loop.Added code to clear the interrupt. Tested with two RP2040's, one sending data to the other.
@ATMakersBill This sounds like it may be the cause the odd behavior you saw on your USB host board. This means causes other than noise could also trigger the original bug.