-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add USB to Serial/JTAG support for REPL #6181
Conversation
Adds Adafruit QT Py C3 board that uses it. Also revamps size check script to work for S3 and C3 as well. Fixes micropython#6030
Also, mark QTPy C3 as BIN only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move supervisor/serial.c out of the port? If needed, have e.g., port_bytes_available()
and such functions that are port-specific.
This makes it easier to integrate port specific serial alongside the common approaches.
Done in the latest commit. 🤞 all of the boards build. |
@jepler I spot checked failures and they all build for me. I can't load the files to know why they failed here. I suspect it's not my problem because they all fail in 4 minutes or less. |
@jepler CI passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! didn't test though
Adds Adafruit QT Py C3 board that uses it. Also revamps size
check script to work for S3 and C3 as well.
Fixes #6030