Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USB to Serial/JTAG support for REPL #6181

Merged
merged 7 commits into from
Mar 23, 2022
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 21, 2022

Adds Adafruit QT Py C3 board that uses it. Also revamps size
check script to work for S3 and C3 as well.

Fixes #6030

Adds Adafruit QT Py C3 board that uses it. Also revamps size
check script to work for S3 and C3 as well.

Fixes micropython#6030
@tannewt tannewt added the espressif applies to multiple Espressif chips label Mar 21, 2022
@tannewt tannewt requested a review from jepler March 21, 2022 22:15
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move supervisor/serial.c out of the port? If needed, have e.g., port_bytes_available() and such functions that are port-specific.

This makes it easier to integrate port specific serial alongside
the common approaches.
@tannewt
Copy link
Member Author

tannewt commented Mar 23, 2022

Can you move supervisor/serial.c out of the port? If needed, have e.g., port_bytes_available() and such functions that are port-specific.

Done in the latest commit. 🤞 all of the boards build.

@tannewt
Copy link
Member Author

tannewt commented Mar 23, 2022

@jepler I spot checked failures and they all build for me. I can't load the files to know why they failed here. I suspect it's not my problem because they all fail in 4 minutes or less.

@tannewt
Copy link
Member Author

tannewt commented Mar 23, 2022

@jepler CI passed!

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! didn't test though

supervisor/shared/serial.c Show resolved Hide resolved
@tannewt tannewt merged commit 8ebab76 into adafruit:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
espressif applies to multiple Espressif chips
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect serial on the ESP32-C3 to the native USB converter
2 participants