Vectorio color index

[FoamyGuy]

Implementing color_index argument and property for all of the vectorio shapes. This allows user to specify which color index to fill the shape from the given palette. Previous behavior was always defaulting to the 0 index within the palette.

There is a script illustrating it's usage in this PR inside of tests/vecotrio/color_index.py

If the argument is omitted the previous behavior is the default.

[kvc0]

This looks right to me

[kvc0]

Oh wow this is a fun capability

[gamblor21]

I didn't test but looked over the code. One question what if I set a color_index outside the range of the palette? I am just unsure if the palette automatically handles and wraps that or if you need a check for the size of the palette vs the color_index.

[FoamyGuy]

@gamblor21 good question on the outside range. There isn't automatic wrapping for values outside the range, however they also don't result in an exception. Current behavior is values outside of the valid range result in the shape being drawn black which is maybe unexpected behavior.

I'll add some more explicit checks that raise an exception for invalid values.

Thanks for having a look over this!

[kvc0]

On valid ranges for color values - it’s really up to the colorconverter/pixelshader/palette to decide what to do with an index out of range, no? I agree with just passing the configured color index straight into the pixel shader as you have it here. Why define a different behavior for invalid indices than the object to which those indices matter?

[FoamyGuy]

That does make sense to me, it would be better to enforce the range within Palette which should then carry over to the usage here if I understand correctly.

[gamblor21]

I did not test but it looks good to me now.

[gamblor21]

That does make sense to me, it would be better to enforce the range within Palette which should then carry over to the usage here if I understand correctly.

Makes sense to me. The original was more of a question just to ensure it was thought of (and possibly a long term issue for Palette if it does not check ranges).

[kvc0]

Thanks folks!