Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix countio.Counter.__init__ type hints #6162

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Fix countio.Counter.__init__ type hints #6162

merged 1 commit into from
Mar 17, 2022

Conversation

prplz
Copy link

@prplz prplz commented Mar 16, 2022

Some fixes with countio.Counter.__init__ typing:

  • Parameter pull was missing its default of None, causing IDEs to falsely warn/error
  • Docstring was missing the name of params edge and pull.

tannewt
tannewt requested changes Mar 16, 2022
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are accidentally changing the esp-idf here too. It was updated yesterday so you may have pulled without updating submodules.

The fix itself looks good. Thanks!

@prplz prplz force-pushed the fix-counter-type-hint branch from 9b2e050 to 84fa7c2 Compare March 16, 2022 20:09
@prplz
Copy link
Author

prplz commented Mar 16, 2022

Oops, I caught that locally but never pushed. Thanks!

dhalbert
dhalbert approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@tannewt tannewt merged commit 851a02d into adafruit:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prplz @tannewt @dhalbert