-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge hexky_s2 board #6135
merge hexky_s2 board #6135
Conversation
Hello, please add support to my custom esp32-s2 board. thanks
Could you say where you got the VID/PID from?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, your mpconfigboard.h
file is using tabs instead of spaces for some indentation. Please use only spaces, and make them line up. I think this is causing the formatting error mentioned in https://github.com/adafruit/circuitpython/runs/5491224618?check_suite_focus=true. You can check for this in your local repo by using pre-commit: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code
my VID/PID from espressif, here is a link to the approval from them |
OKay will check now. thanks |
Great, thanks! |
fixed
Problem now is trailing spaces after the commas in |
Some editors have settings to remove trailing spaces automatically. |
working on that still. had to switch from mac to windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespaces removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for your patience.
Thank you for your help, have a great day |
Hello, please add support to my custom esp32-s2 board.
thanks