Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge hexky_s2 board #6135

Merged
merged 4 commits into from
Mar 11, 2022
Merged

merge hexky_s2 board #6135

merged 4 commits into from
Mar 11, 2022

Conversation

CircuitART
Copy link

Hello, please add support to my custom esp32-s2 board.
thanks

Hello, please add support to my custom esp32-s2 board.
thanks
@dhalbert
Copy link
Collaborator

Could you say where you got the VID/PID from?

USB_VID = 0x303A
USB_PID = 0x80D9

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, your mpconfigboard.h file is using tabs instead of spaces for some indentation. Please use only spaces, and make them line up. I think this is causing the formatting error mentioned in https://github.com/adafruit/circuitpython/runs/5491224618?check_suite_focus=true. You can check for this in your local repo by using pre-commit: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

@CircuitART
Copy link
Author

Could you say where you got the VID/PID from?

USB_VID = 0x303A
USB_PID = 0x80D9

my VID/PID from espressif, here is a link to the approval from them
espressif/usb-pids#32

@CircuitART
Copy link
Author

Hi, your mpconfigboard.h file is using tabs instead of spaces for some indentation. Please use only spaces, and make them line up. I think this is causing the formatting error mentioned in https://github.com/adafruit/circuitpython/runs/5491224618?check_suite_focus=true. You can check for this in your local repo by using pre-commit: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

OKay will check now. thanks

@dhalbert
Copy link
Collaborator

my VID/PID from espressif, here is a link to the approval from them espressif/usb-pids#32

Great, thanks!

@dhalbert
Copy link
Collaborator

Problem now is trailing spaces after the commas in pins.c.

@dhalbert
Copy link
Collaborator

Problem now is trailing spaces after the commas in pins.c.

Some editors have settings to remove trailing spaces automatically.

@CircuitART
Copy link
Author

Problem now is trailing spaces after the commas in pins.c.

Some editors have settings to remove trailing spaces automatically.

working on that still. had to switch from mac to windows

Copy link
Author

@CircuitART CircuitART left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespaces removed

@CircuitART CircuitART requested a review from dhalbert March 11, 2022 05:24
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for your patience.

@dhalbert dhalbert merged commit 862210b into adafruit:main Mar 11, 2022
@CircuitART
Copy link
Author

Thank you for your help, have a great day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants