Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of USB host API #6125

Merged
merged 6 commits into from
Mar 12, 2022
Merged

Start of USB host API #6125

merged 6 commits into from
Mar 12, 2022

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 8, 2022

This allows you to list and explore connected USB devices. It
only stubs out the methods to communicate to endpoints. That will
come in a follow up once TinyUSB has it. (It's in progress.)

Related to #5986

tannewt added 4 commits March 7, 2022 18:07
This allows you to list and explore connected USB devices. It
only stubs out the methods to communicate to endpoints. That will
come in a follow up once TinyUSB has it. (It's in progress.)

Related to micropython#5986
@tannewt tannewt requested a review from jepler March 10, 2022 22:52
@tannewt tannewt marked this pull request as ready for review March 10, 2022 22:52
@tannewt
Copy link
Member Author

tannewt commented Mar 10, 2022

The last build was mostly network failures and one size failure that seems to be unrelated. Please review and I'll likely need to do some tweaks that will lead to another CI run.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't verify the i.MX stuff, though I did look it over. That's what your testing is doing.

Mostly some arg validation stuff. You could make these explicitly called-out TODO's if you don't have time.

Thanks for cleaning up and generalizing the debug UART stuff!

shared-bindings/usb/core/Device.c Outdated Show resolved Hide resolved
shared-bindings/usb/core/Device.c Outdated Show resolved Hide resolved
shared-bindings/usb/core/Device.c Show resolved Hide resolved
shared-bindings/usb/core/__init__.c Outdated Show resolved Hide resolved
shared-module/usb/core/Device.c Outdated Show resolved Hide resolved
shared-module/usb/core/Device.c Outdated Show resolved Hide resolved
shared-module/usb/core/Device.c Outdated Show resolved Hide resolved
shared-module/usb/core/Device.c Outdated Show resolved Hide resolved
shared-module/usb/core/Device.c Outdated Show resolved Hide resolved
@dhalbert
Copy link
Collaborator

One board is not fitting.

@tannewt
Copy link
Member Author

tannewt commented Mar 12, 2022

TinyUSB grew in size:

_usbd_rhport                                                      +1
dcd_mutex_def                                                     +2
dcd_mutex                                                         +4
usbd_int_set                                                     +20
storage_erase_filesystem                                          +8
complex_attr                                                      +2
osal_queue_send.isra.0                                           -16
edpt_dma_start                                                   +36
compile_decorated                                                 -4
mp_obj_exception_attr                                             +4
usbd_edpt_xfer.isra.0                                            +80
compile_atom_expr_normal                                          +4
tusb_hal_nrf_power_event                                          +4
mscd_xfer_cb                                                     +24
mp_qstr_const_attr                                                -4
usb_background                                                   -16
main                                                             +24
mp_qstr_const_pool                                                -8
_usbd_initialized                                                 -1

Total 258461 - 258297                                           +164

@jpconstantineu this disables the traceback module on the bluemicro833. It's new so I figured no code uses it. (Could do watchdog as an alternative.)

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants