Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing BOARD_DICT_STANDARD_ITEMS to two boards #6107

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Add missing BOARD_DICT_STANDARD_ITEMS to two boards #6107

merged 2 commits into from
Mar 7, 2022

Conversation

prplz
Copy link

@prplz prplz commented Mar 2, 2022

Seeed_XIAO_nRF52840_Sense and swan_r5 were missing CIRCUITPYTHON_BOARD_DICT_STANDARD_ITEMS. Tested on the seeed xiao board.

@prplz
Copy link
Author

prplz commented Mar 2, 2022

I snuck in another change relating to 9ad50df (thanks @Neradoc).

jepler
jepler approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jepler jepler merged commit b439464 into adafruit:main Mar 7, 2022
@jepler
Copy link
Member

jepler commented Mar 7, 2022

@prplz hey while you're fresh in the area can you check whether there are a couple more that could use the same fix? I think I found these:

$ git grep --files-without-match BOARD_DICT_STANDARD_ITEMS -- ports/*/boards/*/pins.c
ports/atmel-samd/boards/seeeduino_xiao_kb/pins.c
ports/raspberrypi/boards/melopero_shake_rp2040/pins.c

@prplz prplz mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prplz @jepler