Make countio object long-lived #6106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Mar 2, 2022
There was a problem hiding this comment.
Thanks! I have been thinking about how to fix this without dragging implementation details into shared-bindings, but it's a lot more complicated (keep a list of Counter objects, etc.). This is certainly fine.
Suggestion to add a comment to say why it's long-lived.
Add a comment as to why the countio object needs to be long-lived.
|
There is one build error, but I think it is CI-related. The error does not look like the usual network problems, but it only shows up on one build, and there's nothing special about that build, I think. |
|
Consder backporting to 7.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5982. Made the countio object long-lived so it persists across imports.