update wifi module doc types to str

[FoamyGuy]

If I understand correctly this is the resolution that was discussed here: adafruit/Adafruit_CircuitPython_Typing#5

Changed all of the ReadableBuffer typed arguments in wifi to str

[dhalbert]

I've looked at the low-level stuff in ports/espressif/common-hal/wifi/Radio.c, and it's not so easy. The ESP-IDF routines take uint8_t for the ssid and password, and take const char for the hostname. I don't know if they assume ASCII or not, or just "some bytes".

For the string-like values, we may want to convert them to bytes() before passing them down, and describe them as Union[str | ReadableBuffer]. The fact that you can pass either right now is an accident of MicroPython treating strs as obeying the buffer protocol.

[FoamyGuy]

Latest commit changes mac_address and mac_address_ap back to ReadableBuffer. Also change the str types to be Union[str | ReadableBuffer] and remove the bytes b from the default values that had it.

I think these are the changes that you suggested, but let me know if I've misinterpreted something.

I wasn't sure what you meant by "convert them to bytes() before passing them down" Does it mean like on this line: https://github.com/FoamyGuy/circuitpython/blob/6a792ab373bff7e47adcaffaca02019506037f20/shared-bindings/wifi/Radio.c#L291

it would wrap that value in bytes() call like this?

common_hal_wifi_radio_start_ap(self, bytes(ssid.buf), ssid.len, bytes(password.buf), password.len, args[ARG_channel].u_int, authmode, args[ARG_max_connections].u_int);

[dhalbert]

wasn't sure what you meant by "convert them to bytes() before passing them down" Does it mean like on this line: https://github.com/FoamyGuy/circuitpython/blob/6a792ab373bff7e47adcaffaca02019506037f20/shared-bindings/wifi/Radio.c#L291

it would wrap that value in bytes() call like this?

common_hal_wifi_radio_start_ap(self, bytes(ssid.buf), ssid.len, bytes(password.buf), password.len, args[ARG_channel].u_int, authmode, args[ARG_max_connections].u_int);

Ah, OK, it is already passing raw bytes down, so nothing needs to be done. We can't do bytes(ssid.buf), etc. -- that is strictly a Python construct.

[dhalbert]

OK, I think this is good as it stands. Thanks!