Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LILYGO TTGO T8 ESP32-S2 #6079

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

fabaff
Copy link

@fabaff fabaff commented Feb 21, 2022

Support for the LILYGO TTGO T8 ESP32-S2.

It's heavily based on the already available LILYGO TTGO T8 ESP32-S2 V1.1 ST77789. The main difference seems that this unit doesn't have a display, more GPIOs to use and a third button ("KEY", not implemented at the moment).

@fabaff
Copy link
Author

fabaff commented Feb 22, 2022

Duplicate VID/PID usage found!
 - VID/PID: 0x303a:0x8007
  Boards: lilygo_ttgo_t8_s2, lilygo_ttgo_t8_s2_st7789
$ lsusb
[...]
Bus 003 Device 002: ID 06cb:00f9 Synaptics, Inc. 
Bus 003 Device 046: ID 303a:8007 LILYGO TTGO T8 ESP32-S2

Ignore it?

@ladyada
Copy link
Member

ladyada commented Feb 22, 2022

hi, no they need unique PIDs please!

@tannewt
Copy link
Member

tannewt commented Feb 22, 2022

Looks like the first version is from Espressif so you can request a second one here: https://github.com/espressif/usb-pids You may want to update the description of the original ones as well to make it clear that they have screens and a different pinout.

@fabaff
Copy link
Author

fabaff commented Feb 24, 2022

PID request: espressif/usb-pids#37

@fabaff fabaff force-pushed the lilygo-ttgo-t8 branch 2 times, most recently from 8c23f13 to 802f972 Compare March 8, 2022 13:39
@fabaff
Copy link
Author

fabaff commented Mar 8, 2022

PID: 0x80ED

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge or rebase from adafruit/circuitpython? There should not be a deletion in locale/circuitpython.pot.

@fabaff
Copy link
Author

fabaff commented Mar 8, 2022

Could you merge or rebase from adafruit/circuitpython? There should not be a deletion in locale/circuitpython.pot.

The pot file should no longer be part of the changes. Not sure if the pre-commit hooks somehow interfered because the branch was not up-to-date.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you now submit a PR to https://github.com/adafruit/circuitpython-or for the board?

@dhalbert dhalbert merged commit 16432c8 into adafruit:main Mar 8, 2022
@fabaff
Copy link
Author

fabaff commented Mar 9, 2022

Doc PR: adafruit/circuitpython-org#886

@fabaff fabaff deleted the lilygo-ttgo-t8 branch March 9, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants