Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgpack.unpack requires a readable stream #6073

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

prplz
Copy link

@prplz prplz commented Feb 20, 2022

msgpack.unpack should require read, not write.
This crashes circuitpy if a write-only stream is passed to unpack:

import msgpack
import usb_midi
 # get a write only stream
_, port_out = usb_midi.ports
# before fix: faults
# after fix: OSError: stream operation not supported
msgpack.unpack(port_out)

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

@dhalbert dhalbert merged commit 1603dbb into adafruit:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants