Correct ping timeout for espressif #6006
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5980. Using ESP_PING_PROF_DURATION to check for timeout was always returning zero values until a response was returned. Thus, the code checking for a timeout never detected one. Replaced that check with a manual one using common_hal_time_monotonic_ms().
Note that the actual cause of the crash into safe mode was not determined or corrected; this is a workaround that avoids whatever was going on. It does fix the ping timeout logic, though. Note also that removing the line
esp_ping_get_profile(ping, ESP_PING_PROF_DURATION, &total_time_ms, sizeof(total_time_ms));
which should no longer be needed, can also result in crashes into safe mode.