Track creation of board.I2C(), etc. #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the "ru" build is just a few bytes over on a few of the samd21 builds. |
c1baac0 to
20a17be
Compare
|
I verified this PR now boots properly on the pyportal. Thanks @dhalbert! |
tannewt
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #5422, the singletons for
board.I2C()were stored asi2c_singleton, etc. and wereNULLif not instantiated. #5422 allowed multipleboard, objects, but removed the separate singleton storage slots, and relied on checking whether the objects weredeinited()or not to see if they were valid. But all-zero objects were not recognized asdeinited()in some ports (which caused crashes). For instance, inatmel-samd,deinited()checked for a pin beingNO_PIN(which is 0xFF).So restore tracking the creation of the singletons, and don't use
deinited()to check their existence. This PR tracks them as booleans, instead of as pointers. The changed code now looks more like the code pre-#5422.Tested on a Metro M4, with an I2C program that uses the default I2C object.