Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed common_hal_busio_uart_deinited incorrect pin assignment check. #5945

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

EmergReanimator
Copy link

The pin must be tested instead of pin->number in the same way as in STM
I2C busio layer.

 pytest -s -v test_busio.py --port=/dev/ttyACM2 --html-report=./report/stm32_f4ve.html
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.10.1, pytest-6.2.4, py-1.11.0, pluggy-0.13.1 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /work/external/repos/circuitpython/tests/circuitpython-r
[report-stm32_f4ve.zip](https://github.com/adafruit/circuitpython/files/7964098/report-stm32_f4ve.zip)
egression
plugins: html-reporter-0.2.6
collected 6 items                                                                                                                                                                                                                            

test_busio.py::Test_SPI::test_SPI PASSED
test_busio.py::Test_SPI::test_configure PASSED
test_busio.py::Test_SPI::test_frequency PASSED
test_busio.py::Test_SPI::test_try_lock PASSED
test_busio.py::Test_SPI::test_unlock PASSED
test_busio.py::Test_SPI::test_write PASSED

============================================================================================================= 6 passed in 3.78s ==============================================================================================================

The pin must be tested instead of pin->number in the same way as in STM
I2C busio layer.
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@ladyada ladyada merged commit 7ba23ff into adafruit:main Jan 29, 2022
@EmergReanimator EmergReanimator deleted the stm_deinited_fix branch January 31, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants