Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial support for my new TinyS3, FeatherS3 and ProS3 #5940

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Added initial support for my new TinyS3, FeatherS3 and ProS3 #5940

merged 1 commit into from
Jan 29, 2022

Conversation

UnexpectedMaker
Copy link

Added definitions for my new ESP32-S3 boards.
PIDs are from Espressif.

@prplz
Copy link

prplz commented Jan 29, 2022

USB, flash and RAM never_resets don't need to be specified since: d99847b

@UnexpectedMaker
Copy link
Author

Hmm, ok, I'll go clean that up and also fix my pre-commit issues. Cheers!

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the silk on these boards is, but you want to put the preferred name for a pin first in pins.c lists, so that it will print out that way and also will be used as the preferred pin name for the "PrettyPins" diagrams. See #5652 for an example of where we reordered pin names.

Doing this as a "Request changes" just to flag it for attention.

@UnexpectedMaker
Copy link
Author

I don't know what the silk on these boards is, but you want to put the preferred name for a pin first in pins.c lists, so that it will print out that way and also will be used as the preferred pin name for the "PrettyPins" diagrams. See #5652 for an example of where we reordered pin names.

Doing this as a "Request changes" just to flag it for attention.

Hey Dan,

This is my preferred order for pins. Silkscreen is IO. I only include Dx and Ax for compatibility, but Dx and Ax should die in a big fire as it’s old legacy Arduino style and totally foreign to ESP32.

I don’t use prettypins. My reference cards show IO first with Dx and Ax after.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, all set then!

@dhalbert dhalbert merged commit 472cbcf into adafruit:main Jan 29, 2022
@UnexpectedMaker
Copy link
Author

For reference, this is what my pinout diagrams look like...
pins_feathers3

And is how all of my boards have been ordered in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants