-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BLE scanning for S3 and C3. #5927
Conversation
Everything else should raise NotImplementedError. First step in micropython#5926
Tested on ESP32-S3. Advertisement worked fine, connect did throw a NotImplementedError. So, patch looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it is coming along nicely! I did not test yet.
I think it would be good to add // TODO
on every routine that needs implementation, or needs more implementation. That will help us spot what remains to redo.
My plan was to search for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked some places that should be flagged as NYI.
Also you can add yourself to the copyright on a bunch of files that you're doing a rewrite on,
There are some other places too I marked. |
Ah, I didn't do a bunch of functions because I just did the construct method. Will add a bunch of TODOs for those spots. |
Ok @dhalbert, this is ready for a re-review and passes CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great -- thanks!
Everything else should raise NotImplementedError.
First step in #5926