enable binascii in microbit_v2 build #5925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ampy and rshell both import ubinascii when reading files from a device.
I modified ampy to import binascii if ubinascii is not avaliable
This PR enables binascii in the microbit_v2 build so it is possible to use ampy ( and possible rshell with a similar fix)
I have tested this with a microbit_v2 and my modified ampy and it is working
prior to this PR, a "get" failed with
with binascii enabled
I plan to submit a PR to ampy to to implement the changes I had to make to use it.