Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only make CIRCUITPY readonly with USB #5902

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jan 21, 2022

CIRCUITPY will be writable from CP on all non-USB boards now. This
includes micro:bit v2 and C3 boards. It should allow it to work
with serial file loading programs.

Fixes #5901

CIRCUITPY will be writable from CP on all non-USB boards now. This
includes micro:bit v2 and C3 boards. It should allow it to work
with serial file loading programs.

Fixes micropython#5901
@jerryneedell
Copy link
Collaborator

jerryneedell commented Jan 21, 2022

Tested on c3 devkit -- I was able to upload a file with ampy!!
Also verified that a "normal" build feather_esp32s2_tft still allows write via USB

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@microdev1 microdev1 merged commit bed724f into adafruit:main Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make FS writable by CP if USB is disabled
4 participants