Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add softdev_version 7.0.1 #5877

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Add softdev_version 7.0.1 #5877

merged 2 commits into from
Jan 18, 2022

Conversation

0hotpotman0
Copy link

No description provided.

@dhalbert
Copy link
Collaborator

Could I ask: have you built and tested this, and it works? It looks like this is the only change you need, but this is the first nRF52840 that has been tried with SD 7.0.1.

@0hotpotman0
Copy link
Author

Could I ask: have you built and tested this, and it works? It looks like this is the only change you need, but this is the first nRF52840 that has been tried with SD 7.0.1.

Hi @dhalbert

Yes, without the SD 7.0.1, the start address will be 26000, but add 7.0.1 it will be 27000 then.

Best regards

dhalbert
dhalbert approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks sufficient for me. Thanks for verifying the testing!

@dhalbert dhalbert merged commit 09bdad6 into adafruit:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0hotpotman0 @dhalbert