Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ulab 4.0.0 #5859

Merged
merged 1 commit into from
Jan 17, 2022
Merged

update to ulab 4.0.0 #5859

merged 1 commit into from
Jan 17, 2022

Conversation

jepler
Copy link
Member

@jepler jepler commented Jan 14, 2022

No description provided.

@jepler jepler added the ulab Related to the ulab module label Jan 14, 2022
@tannewt
Copy link
Member

tannewt commented Jan 14, 2022

Does this change any APIs?

@jepler
Copy link
Member Author

jepler commented Jan 14, 2022

Does this change any APIs?

@v923z can you take a moment to answer?

I know it optionally introduces new APIs, but the big thing (complex numbers) remains disabled in CP.

@v923z
Copy link

v923z commented Jan 14, 2022

Does this change any APIs?

@v923z can you take a moment to answer?

I know it optionally introduces new APIs, but the big thing (complex numbers) remains disabled in CP.

If complex is disabled, then there isn't any difference. There are two new functions, but you can disable them in the header file.

I don't know if you want to resolve this v923z/micropython-ulab#435 before merging into CP.

@dhalbert
Copy link
Collaborator

I don't know if you want to resolve this v923z/micropython-ulab#435 before merging into CP.

@jepler: I can approve this, just wanted to follow up on the above.

@dhalbert dhalbert merged commit 4f4b9bd into adafruit:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ulab Related to the ulab module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants