Add floppyio #5852
Merged
Add floppyio #5852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The port is free to return NULL for any/all of these, and the caller has to check. This will be used in the floppy code, because aside from getting the registers, it looks like all is independent of MCU.
Initially enabled for samd51, this enables reading raw flux data as well as DOS/MFM formatted media. This is only the low-level code for reading & decoding flux pulses from a floppy drive. high level details will live in a Python library. adafruit-circuitpython-floppy will take care of details like stepping from track to track, etc.
|
Let's hold this for a bit, @ladyada wants to re-org files in Adafruit_Floppy, which we submodule here. |
Tested on RP2040 Feather with a 3.5" Prodigy diskette, the whole surface reads 100% across 3+ trials.
|
@jepler Are you still waiting for a review? I thought you might be still churning this on a daily basis. |
|
I think there'll still be churn before this is really ready to go in, so we can close it or switch it to draft. |
|
I made it draft, np. |
This is needed so that the floppy flux reader can enable the pull up on the index pin while using it as a pio jmp pin. Also fixes a doc bug where the `jmp_pin` was omitted in one spot in the docs.
I don't understand how this stopped fitting, as none of the added code is used in this build.
|
I need to go through a round of testing on this, but we decided to go ahead with this limited functionality in CircuitPython. Most users will probably want to use Arduino for more advanced stuff (or just the gw-compatible firmware), and that's OK. After I re-test mfm floppy reading on hardware, I'll set this as ready for review. |
|
I brought this up to date and re-tested with a Feather M4 & 5.25" floppy drive. |
dhalbert
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially enabled for samd51, this enables reading raw flux data as well as DOS/MFM formatted media.
This is only the low-level code for reading & decoding flux pulses from a floppy drive. high level details will live in a Python library.
Adafruit_CircuitPython_floppy takes care of details like stepping from track to track, etc.