Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32S2 camera board draft #5832

Merged
merged 15 commits into from
Jan 19, 2022
Merged

ESP32S2 camera board draft #5832

merged 15 commits into from
Jan 19, 2022

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Jan 11, 2022

No description provided.

@ladyada ladyada marked this pull request as draft January 11, 2022 06:14
@jepler
Copy link
Member

jepler commented Jan 12, 2022

looks like this'll need the SPI fix we discussed for the feather esp32s2 tft, I think you know it, but just a reminder :)

@ladyada ladyada requested a review from tannewt January 19, 2022 02:06
@ladyada ladyada marked this pull request as ready for review January 19, 2022 02:06
tannewt
tannewt requested changes Jan 19, 2022
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the S3 qtpy pins are for an earlier rev. I wasn't able to check the camera board pins.

ports/espressif/boards/adafruit_qtpy_esp32s3_nopsram/pins.c Show resolved Hide resolved
ports/espressif/boards/adafruit_qtpy_esp32s3_nopsram/pins.c Outdated Show resolved Hide resolved
ports/espressif/boards/adafruit_qtpy_esp32s3_nopsram/pins.c Show resolved Hide resolved
ports/espressif/boards/adafruit_esp32s2_camera/pins.c Show resolved Hide resolved
tannewt
tannewt approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. This looks good to me!

@tannewt tannewt merged commit 42fbebe into adafruit:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ladyada @jepler @tannewt