Broadcom: Set JTAG pins to Pull Down on initialization #5798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whoops -- there is a logic flaw -- I need to remove the return and let the other if/else set it to Pull-down |
|
fixed and rested on cm4io and pi4b -- still seems to "do no harm" |
KurtE
pushed a commit
to KurtE/circuitpython
that referenced
this pull request
Apr 21, 2022
The following fixes are made: - cancelling a gather now cancels all sub-tasks of the gather (previously it would only cancel the first) - if any sub-task of a gather raises an exception then the gather finishes (previously it would only finish if the first sub-task raised) Fixes issues adafruit#5798, adafruit#7807, adafruit#7901. Signed-off-by: Damien George <damien@micropython.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to comply with the data sheet, explicitly set the JTAG pins to pull-down when reset.
Addresses #5787
Tested on cm4io and pi4b -- has no apparent impact. Worked before and after.