-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feather ESP32-S2: turn on I2C power after reset #5779
Feather ESP32-S2: turn on I2C power after reset #5779
Conversation
I'm not sure about this change. Specifically, I think it may behave differently when merged to main, where we've taken and specifically fae6d47 where we now ensure that a "never reset" pin continues is marked as "in use" after This was needed to resolve a problem where the state of a displayio backlight pin was lost over soft resets. |
That must be why it didn't work when I tested with an artifact from #5776. |
@ladyada and I talked about turning on the power-enable in But #5674 makes the backlight pin unavailable for setting manually, I think. Is that OK? |
This is true only on I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that did it! works great
can u cherrypick into 7.1? |
This is already against 7.1.x, so it will go into 7.1.0-rc.1. We'll merge it into main as well. |
ok rad thanks! this should help with customer confusions |
This is the pretty much the same as #5776, but is a PR against 7.1.x instead of main. I read the code and could not understand why it didn't work, and after trying it myself, I was unable to repoduce the
D7 in use
message.@ladyada, could you test, in your own way? I was using this, with the
DigitalInOut
commented out and not.