Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating UF2_FAMILY_ID for nrf52833 #5775

Merged
merged 1 commit into from
Dec 25, 2021
Merged

updating UF2_FAMILY_ID for nrf52833 #5775

merged 1 commit into from
Dec 25, 2021

Conversation

jpconstantineau
Copy link

Resolves issue #5772

@jpconstantineau
Copy link
Author

Tested on both BlueMicro833 and PCA10100 - two nRF52833 boards.
I both flashed the latest bootloader and then the UF2 from this PR.
Both loaded up fine.

I also tested loading a prior build UF2 onto the new bootloader and it simply refuses to load - as expected.
I also tested loading a feather840 express from this build on a feather840 and that still works as expected.

Unless there is something else that need checking, I believe this can be merged in without any issue

microdev1
microdev1 approved these changes Dec 25, 2021
View reviewed changes
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jpconstantineau.

@microdev1 microdev1 merged commit dd6f9ab into adafruit:main Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microdev1 microdev1 microdev1 approved these changes

Assignees
No one assigned
Labels
enhancement nordic tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpconstantineau @microdev1