Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PIDs to match official espressif list #5691

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Fix PIDs to match official espressif list #5691

merged 2 commits into from
Dec 9, 2021

Conversation

jepler
Copy link
Member

@jepler jepler commented Dec 9, 2021

anecdata
anecdata previously approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@anecdata anecdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anecdata
Copy link
Member

anecdata commented Dec 9, 2021

oh, except I guess we need to delete the duplicate check?

@jepler
Copy link
Member Author

jepler commented Dec 9, 2021

oops, I'd changed that locally but forgot to commit!

@jepler jepler requested a review from anecdata December 9, 2021 02:47
anecdata
anecdata approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@anecdata anecdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for real this time. Passed all checks, numbers match Espressif registry.

@dhalbert dhalbert merged commit 3bdf2a5 into adafruit:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anecdata anecdata anecdata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jepler @anecdata @dhalbert